Issue Bug Closed

#101701PathUtility::getAbsoluteWebPath() create wrong asset path in composer with TYPO3 12

Sven Juergens 08/16/23, 20:16 updated 07/09/24, 14:15

Description

There is an error in the path generation in connection with TYPO3 12 and PathUtility::getAbsoluteWebPath() in Composer.
if the asset path contains “Resources/Public” more than once.

Example:
- TYPO3 12 installation with composer
- Installing news
- Installation “sitepackage” (for example)
copy “news-basic.css” to sitepackage to the following path:
sitepackage/Resources/Public/ExtensionOverwrite/news/Resources/Public/Css/
then use this TypoScript

plugin.tx_news {
    settings {
        cssFile = EXT:sitepackage/Resources/Public/ExtensionOverwrite/news/Resources/Public/Css/news-basic.css
    }
}

Generated Path:

<link href="/_assets/bb36f0f8e61571e2a51d4a09a953e97d/ExtensionOverwrite/news/?1692215767" rel="stylesheet" >

Should:

<link href="/_assets/bb36f0f8e61571e2a51d4a09a953e97d/ExtensionOverwrite/news/Resources/Public/Css/news-basic.css?1692215826" rel="stylesheet" >

Problem is this line in in PathUtility::class
https://github.com/TYPO3/typo3/blob/d7f24355efc58fb6f749fd26214a3d43e9d0ed24/typo3/sysext/core/Classes/Utility/PathUtility.php#L69

Because “Resources/Public” occurs several times, a problem arises in connection with explode()
The problem could be solved with a limit in explode().

                [$relativePrefix, $relativeAssetPath] = explode('Resources/Public', $relativePath, 2);

Reviews 2

History 58

  1. Sven Juergens commented 08/16/23, 20:28

    may be it’s helpful:
    the problem does not exist in TYPO3 11, as this check returns true if the extension is in typo3conf/ext/.
    The path checked here is then (with ddev)

    $targetPath:
    /var/www/html/public/typo3conf/ext/sitepackage/Resources/Public/ExtensionOverwrite/news/Resources/Public/Css/news-basic.css
    
    Environment::getPublicPath():
    "/var/www/html/public"

    in TYPO3 12

    $targetPath:
    /var/www/html/vendor/typo3conf/ext/sitepackage/Resources/Public/ExtensionOverwrite/news/Resources/Public/Css/news-basic.css
    
    Environment::getPublicPath():
    "/var/www/html/public"
  2. Garvin Hicking changed Related to #101911 09/14/23, 14:22

  3. Garvin Hicking changed Related to #101911 05/08/24, 16:08

  4. Gerrit Code Review pushed patch set 1 for main to change 84181 status New Under Review 05/08/24, 17:04

  5. Gerrit Code Review pushed patch set 2 for main to change 84181 05/08/24, 17:13

  6. Gerrit Code Review pushed patch set 1 for 12.4 to change 84194 05/10/24, 07:12

  7. Markus Klein commented and changed status Under Review Resolved done 0 % 100 % 05/10/24, 07:20

    Applied in changeset commit:19a2d873e6974060456080d2340d1c19a49bae26.

  8. Benni Mack changed status Resolved Closed 07/09/24, 14:15