Review main Merged

84513[BUGFIX] Prevent runTests.sh from removing wrong generated docs files

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 06/06/24, 15:45

Commit message

The directory to reference removing Documentation-GENERATED-temp
breaks out of the current working directory scope and could
possibly delete files in a completely unrelated directory. Also,
it does not remove the actual temporary files.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Patrick Schriner +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Patrick Schriner +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Garvin Hicking uploaded patch set 1 06/06/24, 14:51

  2. core-ci voted on patch set 1 V +1 06/06/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58803

  3. Stefan Bürk updated the commit message in patch set 2 V +1 06/06/24, 15:16

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 06/06/24, 15:18

  5. core-ci voted on patch set 2 V +1 06/06/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58806

  6. Jochen Roth voted on patch set 2 CR +1 V +1 06/06/24, 15:42

  7. Patrick Schriner voted on patch set 2 CR +1 V +1 06/06/24, 15:43

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 06/06/24, 15:45

  9. Stefan Bürk merged patch set 3 06/06/24, 15:45