Issue Bug Closed

#103989runTests.sh tries to remove Documentation-GENERATED-temp files outside the project directory scope

Garvin Hicking 06/06/24, 14:48 updated 07/09/24, 15:35

Description

Given a TYPO3 git in:

/Users/garvin/TYPO3/GIT

when executing:

/Users/garvin/contrib/TYPO3/GIT/Build/Scripts/runTests.sh -s clean

this will try to remove all files from:

/Users/garvin/typo3/sysext/*/Documentation-GENERATED-temp

due to cleanRenderedDocumentationFiles referencing files from “../../../typo3/…”.

The current script context however is the project root directory, so this will break out three levels outside that.

Luckily the final directory D@ocumentation-GENERATED-temp@ should never match critical system files from a user.

But the current reference didn’t actually remove the documentation temporary files. This needs to be adapted to to not break out of the main script directory.

Reviews 3

History 26

  1. Gerrit Code Review pushed patch set 1 for main to change 84513 status New Under Review 06/06/24, 14:51

  2. Gerrit Code Review pushed patch set 2 for main to change 84513 06/06/24, 15:16

  3. Gerrit Code Review pushed patch set 1 for 12.4 to change 84464 06/06/24, 15:21

  4. Gerrit Code Review pushed patch set 1 for 11.5 to change 84465 06/06/24, 15:21

  5. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % 06/06/24, 15:50

    Applied in changeset commit:094e2bec68272469e6dc0e792df61200b86ea6ee.

  6. Benni Mack changed status Resolved Closed 07/09/24, 15:35