Review main Merged

84925[BUGFIX] Do not redirect to password reset after successful login

Xavier Perseguers CR +2 V +2 Easy +23 −1 updated 07/11/24, 21:01

Commit message

When the plugin is configured to use the referrer to redirect after a
successful login, it should not honor it when the referrer is the
password reset form and the user just updated their password.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1013

  1. Xavier Perseguers uploaded patch set 1 06/26/24, 09:29

  2. Xavier Perseguers commented on patch set 1 06/26/24, 09:30

  3. core-ci voted on patch set 1 V +1 06/26/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60364

  4. Torben Hansen uploaded patch set 2 V +1 06/27/24, 16:53

  5. Torben Hansen rebased onto patch set 3 06/27/24, 16:59

  6. core-ci voted on patch set 2 V -1 06/27/24, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60480

  7. core-ci voted on patch set 3 V +1 06/27/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60481

  8. Torben Hansen commented on patch set 3 CR +1 V +1 06/27/24, 17:06

    I added a unit test for the scenario and removed TYPO3 11.5 as target version for this patch, since 11.5 is in priority bugfix mode only. Additionally, I also added #101581 as resolving issue and rebased the patch.
  9. Xavier Perseguers commented on patch set 3 06/27/24, 17:13

    Reply

    I added 11.5 as I'm using v11 and this bug was fixed 12 years ago (!) and it popped up again with the rewrite as Extbase, so it's a regression. But I'm fine if this is not considered as a priority bug fix, indeed, looks like it does not bother so many users. And I have already applied the patch for myself :)
  10. Benni Mack commented on patch set 3 06/27/24, 17:43

    Reply

    Hey Xavier, I ran into this issue in v12 just last week, and fixed this by using a PSR-14 event in v12 just in my custom project. I can see if I can test this soon. Thank you for creating the patch
  11. Xavier Perseguers commented on patch set 3 07/08/24, 14:04

    Reply

    Sure, you can handle that with PSR-14 "locally" but this is supposed to work out-of-the-box :)
  12. Benni Mack voted on patch set 3 CR +2 V +2 07/11/24, 21:01

  13. Benni Mack merged patch set 4 07/11/24, 21:01