Issue Bug Closed

#101581felogin gives "1554994253: The link you clicked is not valid. Please repeat the forgot password procedure" on first login after password reset

Simon Child 08/04/23, 19:48 updated 10/15/24, 09:30

Description

Click ‘Forgot your password’ link, enter email address, click link in email received, set new password which meets the validation policy

When the new password is accepted the message is displayed

“1554994253: The link you clicked is not valid. Please repeat the forgot password procedure.”

Yet the login has succeeded as can be shown by reloading the login page and seeing the logout button.

This only occurs on the first login after a password rest, and only if using the login box shown immediately after the new password is set. If I reload the page, after setting the password but before logging in, then login is successful first attempt.

TYPO3 12.4.4, on Ubuntu 22.4 LTS with Plesk 18.0.53

Server set to “(GMT +01:00) Europe/London” and PHP setting date.timezone = Europe/London (no change if I comment this out).

Bug? User error??

Reviews 2

History 710

  1. Simon Child commented 08/05/23, 07:52

    Apologies, error in the above

    Where I said

    - When the new password is accepted the message is displayed
    - “1554994253: The link you clicked is not valid. Please repeat the forgot password procedure.”

    I omitted a step.

    I should have said

    - When the new password is accepted a login box is displayed
    - When I enter email and new password the following is displayed “1554994253: The link you clicked is not valid. Please repeat the forgot password procedure.”
  2. Torben Hansen commented and changed status New Needs Feedback 09/04/23, 16:30

    Do you have any redirects configured (e.g. Redirect by referer)?

  3. Simon Child commented 09/11/23, 20:08

    Thanks for the response. Yes I do have login redirects configured.

    I wondered whether that was relevant and so before submitting the above I commented out the configuration for redirects and the problem continued.

    I just tested again, commenting out all redirect configuration and clearing cache and still the problem was there. But then I found styles.content.loginform.redirectDisable and set that to 1. That resolved the problem logging in after password reset, but at the cost of losing the benefit of redirects on login.

    So as you thought there appears to be some unwanted interaction between redirects being configured and logging in after password reset.

  4. Simon Child commented 10/30/23, 17:01

    I can fix this now, and reproduce it again.

    • If I set the felogin flexform redirect configuration to referer only then the above error occurs.
    • If I change that to getpost only then I do not get that error.
    • Change it back to referer and the error recurs.

    I have the following typoscript on my root page:

    config {
    typolinkLinkAccessRestrictedPages = 363
    typolinkLinkAccessRestrictedPages_addParams = &redirect_url=###RETURN_URL###
    }

    plugin.tx_felogin_login.settings.redirectMode = getpost

  5. Torben Hansen changed Related to #104214 06/27/24, 16:25

  6. Gerrit Code Review pushed patch set 2 for main to change 84925 status Needs Feedback Under Review 06/27/24, 16:53

  7. Gerrit Code Review pushed patch set 3 for main to change 84925 06/27/24, 16:59

  8. Gerrit Code Review pushed patch set 1 for 12.4 to change 85195 07/11/24, 21:02

  9. Anonymous commented and changed status Under Review Resolved done 0 % 100 % 07/11/24, 21:05

    Applied in changeset commit:007367dc0e1b0cfc1c07ca8d791dccefa66bff7c.

  10. Benni Mack changed status Resolved Closed 10/15/24, 09:30