Review 12.4 Merged

84960[BUGFIX] Fix invalid FormEngine HTML structure on edge-case

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 06/29/24, 13:11

Commit message

When the TCA type "group" or "folder" is rendered in FormEngine,
under certain circumstances the HTML structure would close add
`<div>` elements without opening those first. This will lead
to a record not being editable, because variables are wrongly
transferred due to the browser-rendering of wrong HTML nesting
levels.

This behaviour is an edge case and only happens with this TCA
configuration:

* either `config[hideMoveIcons]` is set to `true`
* or `config[hideDeleteIcon]` is set to `true`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 06/29/24, 13:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/29/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60630

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 06/29/24, 13:11

  4. Stefan Bürk merged patch set 2 06/29/24, 13:11