85108[TASK] Update list of devices for EXT:viewpage
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2633
Show 68 earlier messages
-
Georg Ringer uploaded patch set 1 07/04/24, 20:41
-
Georg Ringer commented on patch set 1 07/04/24, 20:41
This change is ready for review. -
core-ci voted on patch set 1 V +1 07/04/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60988
-
Oli Bartsch commented on patch set 1 07/05/24, 07:06
In this step, could we also remove outdated devices? -
Benni Mack commented on patch set 1 07/05/24, 09:42
Reply
As this goes into 12.4 as well, I wouldn't do that. In contrast, I would rather suggest, to move the new list of items to the top of the list. -
Georg Ringer updated the commit message in patch set 2
V +107/10/24, 19:12 -
Georg Ringer commented on patch set 2 07/10/24, 19:13
Reply
the items are sorted in viewpage again, the order in tsconfig doesn't matter. As there are some additional entries I thought 12.4 is fine but fine as well with having just in main - adopted the commit msg -
core-ci voted on patch set 2 V +1 07/10/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61329
-
Benni Mack commented on patch set 2 CR +1 V +1 07/11/24, 12:00
Reply
Done -
Torben Hansen commented on patch set 2 07/11/24, 12:28
As this is for main only now, I agree with Oli, that we should remove outdated devices. The dropdown list currently has 22 items. -
Christian Kuhn commented on patch set 2 CR -1 07/11/24, 12:38
I would strongly recommend to go a step further: This list of arbitrary vendors is fishy, needs constant adaption and can never be complete. Let's remove them all and substitute them with some "typical" sets: 1-2 typical desktop resolutions, same for "pads" and same for "mobile". And that's it. If then some customer wants a special entry, it can be managed by agencies. -
Benni Mack commented on patch set 3
CR +1V +107/11/24, 19:11Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 07/11/24, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61411
-
Christian Kuhn voted on patch set 3 CR -1 07/11/24, 19:21
-
Christian Kuhn uploaded patch set 4
CR -1V -112/19/24, 11:36 -
Christian Kuhn commented on patch set 4 12/19/24, 11:36
Reply
Done -
core-ci voted on patch set 4 V -1 12/19/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71447
-
Christian Kuhn uploaded patch set 5
V -112/19/24, 11:58 -
Christian Kuhn uploaded patch set 6 12/19/24, 12:00
-
core-ci voted on patch set 5 V +1 12/19/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71452
-
core-ci voted on patch set 6 V +1 12/19/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71453
-
Christian Kuhn voted on patch set 6 CR +1 V +1 12/19/24, 12:07
-
Torben Hansen voted on patch set 6 CR +1 V +1 12/19/24, 12:22
-
Jasmina Ließmann commented on patch set 6 12/19/24, 13:55
locallang.xlf:21From what I see, this label is no longer used with this patch. Should we remove it? -
Christian Kuhn uploaded patch set 7
CR +1V +112/19/24, 13:58 -
Christian Kuhn commented on patch set 7 CR +1 V +1 12/19/24, 13:59
locallang.xlf:21ReplyDone -
Jasmina Ließmann commented on patch set 6 12/19/24, 14:04
locallang.xlf:21ReplyHmm, and it seems to be the same with the following language keys? - width - tablet - customWidth - autoSize - automatic - unidentified -
Christian Kuhn commented on patch set 7 12/19/24, 14:06
locallang.xlf:21Replyunsure. i think removing those should then be a dedicated patch since it is unrelated to this change. is that ok with you? -
core-ci voted on patch set 7 V +1 12/19/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71455
-
Jasmina Ließmann commented on patch set 7 CR +1 V +1 12/19/24, 14:09
locallang.xlf:21ReplyYes, ok. -
Benni Mack voted on patch set 7 CR +1 12/19/24, 15:47
-
Christian Kuhn voted on patch set 7 CR +2 V +2 12/19/24, 16:13
-
Christian Kuhn merged patch set 8 12/19/24, 16:13