Issue Task Closed

#100185Update device presets in view module

Florian Seirer 03/16/23, 12:26 updated 12/02/25, 14:33

Description

The device presets introduced in #77576 and defined in mod.web_view.previewFrameWidths are quite outdated and could use an update, especially the smartphones:
  • Nexus 6P (Released in 2015)
  • iPhone 7 Plus (Released in 2016)
  • iPhone 6
  • iPhone 5
  • iPhone 4

Reviews 2

Files 1

History 917

  1. Florian Seirer commented 03/16/23, 14:03

    To make the list more up to date without using actual device names the list could instead have resolutions/breakpoints used by popular devices like:
    • 1920 × 1080
    • 768 × 1024
    • 360 × 640
    • …

    I’m sure there are some statistics (Google Analytics?) out there with a list of the most used screen resolutions or breakpoints.

  2. Georg Ringer commented and changed status New Accepted 03/16/23, 20:01

    I suggest to remove outdated in main and just add additonal ones in 11.5

  3. Georg Ringer changed Sprint Focus On Location Sprint 06/10/24, 19:23

  4. Gerrit Code Review pushed patch set 1 for main to change 85108 status Accepted Under Review 07/04/24, 20:41

  5. Gerrit Code Review pushed patch set 2 for main to change 85108 07/10/24, 19:12

  6. Gerrit Code Review pushed patch set 3 for main to change 85108 07/11/24, 19:11

  7. Christian Kuhn changed Related to #105752 12/03/24, 14:08

  8. Gerrit Code Review pushed patch set 4 for main to change 85108 12/19/24, 11:36

  9. Christian Kuhn changed attached Screenshot from 2024-12-19 12-37-25.png 12/19/24, 11:37

  10. Christian Kuhn changed Related to #105752 12/19/24, 11:39

  11. Christian Kuhn changed Duplicated by #105752 12/19/24, 11:39

  12. Gerrit Code Review pushed patch set 5 for main to change 85108 12/19/24, 11:58

  13. Gerrit Code Review pushed patch set 6 for main to change 85108 12/19/24, 12:00

  14. Gerrit Code Review pushed patch set 7 for main to change 85108 12/19/24, 13:58

  15. Gerrit Code Review pushed patch set 1 for 13.4 to change 87572 12/19/24, 16:01

  16. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 12/19/24, 16:15

    Applied in changeset commit:63a4da4c23d4c8686d8f7b7438f466be63173bc2.

  17. Benni Mack changed status Resolved Closed 12/02/25, 14:33