Review main Merged

87586[TASK] Avoid invalid reuse of QueryBuilder in Typo3DatabaseBackend

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 12/29/24, 09:17

Commit message

Reuse of a QueryBuilder instance for multiple queries and
specifically different types (UPDATE/DELETE/SELECT/...) is
not recommended and **must** be avoided.

This change creates a new instance within a method of the
Typo3DatabaseBackend, dealing with multiple queries in one
method. This prevents previous settings to affect
the actual query.

This issue was detected with implementation of #105387.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Stefan Bürk uploaded patch set 1 12/23/24, 21:42

  2. core-ci voted on patch set 1 V +1 12/23/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71580

  3. Garvin Hicking updated the commit message in patch set 2 V +1 12/23/24, 22:48

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 12/23/24, 22:48

  5. core-ci voted on patch set 2 V +1 12/23/24, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71583

  6. Torben Hansen voted on patch set 2 CR +1 V +1 12/24/24, 06:00

  7. Chris Müller voted on patch set 2 CR +1 12/24/24, 08:05

  8. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 12/28/24, 12:08

  9. core-ci voted on patch set 3 V +1 12/28/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71670

  10. Torben Hansen voted on patch set 3 CR +1 V +1 12/28/24, 12:21

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 12/28/24, 14:32

  12. Stefan Bürk voted on patch set 3 CR +2 V +2 12/29/24, 08:59

  13. Stefan Bürk merged patch set 4 12/29/24, 09:17