Issue Task Closed

#105387Add an exception for update or delete with join and queryBuilder

Florian Rival 10/22/24, 08:22 updated 08/12/25, 14:36

Description

With queryBuilder, you can make a delete or update query with a join condition like this:

$queryBuilder = $this->connectionPool->getQueryBuilderForTable('tt_content');
$queryBuilder
    ->update('tt_content')
    ->leftJoin('tt_content', 'sys_file_reference')
    ->where(
        $queryBuilder->expr()->eq('tt_content.bodytext', $queryBuilder->createNamedParameter('lorem', Connection::PARAM_STR)),
        $queryBuilder->expr()->eq('sys_file_reference.fieldname', $queryBuilder->createNamedParameter('assets', Connection::PARAM_STR)),
    )
    ->set('tt_content.bodytext', 'dolor')
    ->executeStatement();

but join condition are not supported by doctrine/dbal because the join method is not supported in all db engines for delete or update.

And with queryBuilder this result in an SQL error like:

> (1/3) #1054 Doctrine\DBAL\Exception\InvalidFieldNameException
> An exception occurred while executing a query: Unknown column ‘sys_file_reference.fieldname’ in ‘where clause’

which is not very clear.

I suggest to add an exception in queryBuilder when you try to add a join for an update or a delete.

Reviews 4

History 314

  1. Gerrit Code Review pushed patch set 1 for main to change 87585 status New Under Review 12/23/24, 20:26

  2. Gerrit Code Review pushed patch set 2 for main to change 87585 12/23/24, 20:39

  3. Gerrit Code Review pushed patch set 3 for main to change 87585 12/23/24, 20:47

  4. Gerrit Code Review pushed patch set 4 for main to change 87585 12/23/24, 20:48

  5. Stefan Bürk changed Related to #105861 12/23/24, 21:40

  6. Gerrit Code Review pushed patch set 5 for main to change 87585 12/23/24, 21:42

  7. Gerrit Code Review pushed patch set 6 for main to change 87585 12/23/24, 21:51

  8. Gerrit Code Review pushed patch set 7 for main to change 87585 12/29/24, 09:18

  9. Gerrit Code Review pushed patch set 8 for main to change 87585 12/29/24, 09:31

  10. Gerrit Code Review pushed patch set 9 for main to change 87585 01/02/25, 14:02

  11. Gerrit Code Review pushed patch set 10 for main to change 87585 01/02/25, 14:15

  12. Gerrit Code Review pushed patch set 11 for main to change 87585 01/02/25, 14:21

  13. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 01/02/25, 16:30

    Applied in changeset commit:0913a3db858ed26bcfcc4a06659c1e2cd8d122c8.

  14. Benni Mack changed status Resolved Closed 08/12/25, 14:36