#105387Add an exception for update or delete with join and queryBuilder
Description
With queryBuilder, you can make a delete or update query with a join condition like this:
$queryBuilder = $this->connectionPool->getQueryBuilderForTable('tt_content');
$queryBuilder
->update('tt_content')
->leftJoin('tt_content', 'sys_file_reference')
->where(
$queryBuilder->expr()->eq('tt_content.bodytext', $queryBuilder->createNamedParameter('lorem', Connection::PARAM_STR)),
$queryBuilder->expr()->eq('sys_file_reference.fieldname', $queryBuilder->createNamedParameter('assets', Connection::PARAM_STR)),
)
->set('tt_content.bodytext', 'dolor')
->executeStatement();
but join condition are not supported by doctrine/dbal because the join method is not supported in all db engines for delete or update.
And with queryBuilder this result in an SQL error like:
> (1/3) #1054 Doctrine\DBAL\Exception\InvalidFieldNameException
> An exception occurred while executing a query: Unknown column ‘sys_file_reference.fieldname’ in ‘where clause’
which is not very clear.
I suggest to add an exception in queryBuilder when you try to add a join for an update or a delete.
Reviews 4
- main 87585[TASK] Throw exception for QueryBuilder UPDATE/DELETE with table joins
- 12.4 87601[TASK] Avoid invalid reuse of QueryBuilder in Typo3DatabaseBackend
- 13.4 87600[TASK] Avoid invalid reuse of QueryBuilder in Typo3DatabaseBackend
- main 87586[TASK] Avoid invalid reuse of QueryBuilder in Typo3DatabaseBackend
Related issues 1
History 314
-
Gerrit Code Review pushed patch set 1 for main to change 87585 status
NewUnder Review 12/23/24, 20:26 -
Gerrit Code Review pushed patch set 2 for main to change 87585 12/23/24, 20:39
-
Gerrit Code Review pushed patch set 3 for main to change 87585 12/23/24, 20:47
-
Gerrit Code Review pushed patch set 4 for main to change 87585 12/23/24, 20:48
-
Stefan Bürk changed Related to #105861 12/23/24, 21:40
-
Gerrit Code Review pushed patch set 5 for main to change 87585 12/23/24, 21:42
-
Gerrit Code Review pushed patch set 6 for main to change 87585 12/23/24, 21:51
-
Gerrit Code Review pushed patch set 7 for main to change 87585 12/29/24, 09:18
-
Gerrit Code Review pushed patch set 8 for main to change 87585 12/29/24, 09:31
-
Gerrit Code Review pushed patch set 9 for main to change 87585 01/02/25, 14:02
-
Gerrit Code Review pushed patch set 10 for main to change 87585 01/02/25, 14:15
-
Gerrit Code Review pushed patch set 11 for main to change 87585 01/02/25, 14:21
-
Stefan Bürk commented and changed status
Under ReviewResolved done0 %100 % 01/02/25, 16:30 -
Benni Mack changed status
ResolvedClosed 08/12/25, 14:36
Applied in changeset commit:0913a3db858ed26bcfcc4a06659c1e2cd8d122c8.