Review 13.4 Merged

87764[BUGFIX] Ignore existing nested processing folder on creation

Christian Kuhn CR +2 V +2 Easy +14 −5 updated 01/14/25, 18:25

Commit message

The nested processing folder can be created by a parallel request
between check and creation. For this reason it is safe to ignore an
error if the folder already exists when attempting to create it. This
makes the folder creation idempotent.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/14/25, 17:52

  2. Christian Kuhn commented on patch set 1 01/14/25, 17:55

    this is essentially patch set 5 from the main branch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85101/5 since #105920 is not applied to v13/v12. @stefan@buerk.tech could you have a re-review of the v13 & v12 backport version, please?
  3. core-ci voted on patch set 1 V +1 01/14/25, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72473

  4. Stefan Bürk commented on patch set 1 CR +1 V +1 01/14/25, 18:08

    Reply

    You are welcome. Backport is fine.
  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/14/25, 18:25

  6. Christian Kuhn merged patch set 2 01/14/25, 18:25