Issue Bug Closed

#96727ExistingTargetFolderException not handled correctly

Michael Grundkötter 02/02/22, 09:57 updated 12/02/25, 14:33

Description

In `TYPO3\CMS\Core\Resource\ResourceStorage::getNestedProcessingFolder` there is this code:

foreach ($nestedFolderNames as $folderName) {
    if ($processingFolder->hasFolder($folderName)) {
        $processingFolder = $processingFolder->getSubfolder($folderName);
    } else {
        $currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
        $processingFolder->getStorage()->setEvaluatePermissions(false);
        $processingFolder = $processingFolder->createFolder($folderName);
        $processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
    }
}

and the call to `$processingFolder->createFolder()` can cause an ExistingTargetFolderException, which may be caused by parallel actions of multiple editors or whatever. Although the issue seem to be handled by `$processingFolder->hasFolder($folderName)` right above, the exception does occur in our sentry system nevertheless. Hence, this code block should be changed like this instead to prevent the process from terminating completely:

foreach ($nestedFolderNames as $folderName) {
    if ($processingFolder->hasFolder($folderName)) {
        $processingFolder = $processingFolder->getSubfolder($folderName);
    } else {
        $currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
        $processingFolder->getStorage()->setEvaluatePermissions(false);
        try {
            $processingFolder = $processingFolder->createFolder($folderName);
            $processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
        } catch (ExistingTargetFolderException $existingTargetFolderException) {
            $processingFolder = $processingFolder->getSubfolder($folderName);
        }
    }
}

Reviews 4

History 616

  1. Gerrit Code Review pushed patch set 1 for main to change 85101 status New Under Review 07/04/24, 10:01

  2. Mathias Brodala changed assigned to Mathias Brodala 07/04/24, 10:01

  3. Mathias Brodala commented 07/04/24, 10:41

    We see the same issue by using ichhabrecht/filefill. Here it is expected that files and folders are created by parallel requests.

  4. Gerrit Code Review pushed patch set 2 for main to change 85101 07/05/24, 06:56

  5. Gerrit Code Review pushed patch set 3 for main to change 85101 10/18/24, 13:37

  6. Gerrit Code Review pushed patch set 4 for main to change 85101 10/18/24, 14:22

  7. Gerrit Code Review pushed patch set 5 for main to change 85101 01/13/25, 11:50

  8. Christian Kuhn changed Related to #105920 01/13/25, 14:08

  9. Gerrit Code Review pushed patch set 6 for main to change 85101 01/13/25, 18:10

  10. Gerrit Code Review pushed patch set 7 for main to change 85101 01/13/25, 18:13

  11. Gerrit Code Review pushed patch set 8 for main to change 85101 01/14/25, 09:21

  12. Gerrit Code Review pushed patch set 1 for 13.4 to change 87764 01/14/25, 17:52

  13. Gerrit Code Review pushed patch set 1 for 12.4 to change 87765 01/14/25, 17:59

  14. Mathias Brodala commented and changed status Under Review Resolved done 0 % 100 % 01/14/25, 18:30

    Applied in changeset commit:03027a9cb4c558284289da7007c225aa42a72619.

  15. Benni Mack changed status Resolved Closed 12/02/25, 14:33

  16. Simon Schaufelberger changed Related to #110686 09/12/26, 22:54