#96727ExistingTargetFolderException not handled correctly
Description
In `TYPO3\CMS\Core\Resource\ResourceStorage::getNestedProcessingFolder` there is this code:
foreach ($nestedFolderNames as $folderName) {
if ($processingFolder->hasFolder($folderName)) {
$processingFolder = $processingFolder->getSubfolder($folderName);
} else {
$currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
$processingFolder->getStorage()->setEvaluatePermissions(false);
$processingFolder = $processingFolder->createFolder($folderName);
$processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
}
}
and the call to `$processingFolder->createFolder()` can cause an ExistingTargetFolderException, which may be caused by parallel actions of multiple editors or whatever. Although the issue seem to be handled by `$processingFolder->hasFolder($folderName)` right above, the exception does occur in our sentry system nevertheless. Hence, this code block should be changed like this instead to prevent the process from terminating completely:
foreach ($nestedFolderNames as $folderName) {
if ($processingFolder->hasFolder($folderName)) {
$processingFolder = $processingFolder->getSubfolder($folderName);
} else {
$currentEvaluatePermissions = $processingFolder->getStorage()->getEvaluatePermissions();
$processingFolder->getStorage()->setEvaluatePermissions(false);
try {
$processingFolder = $processingFolder->createFolder($folderName);
$processingFolder->getStorage()->setEvaluatePermissions($currentEvaluatePermissions);
} catch (ExistingTargetFolderException $existingTargetFolderException) {
$processingFolder = $processingFolder->getSubfolder($folderName);
}
}
}Reviews 4
Related issues 2
History 616
-
Gerrit Code Review pushed patch set 1 for main to change 85101 status
NewUnder Review 07/04/24, 10:01 -
Mathias Brodala changed assigned to Mathias Brodala 07/04/24, 10:01
-
Mathias Brodala commented 07/04/24, 10:41
-
Gerrit Code Review pushed patch set 2 for main to change 85101 07/05/24, 06:56
-
Gerrit Code Review pushed patch set 3 for main to change 85101 10/18/24, 13:37
-
Gerrit Code Review pushed patch set 4 for main to change 85101 10/18/24, 14:22
-
Gerrit Code Review pushed patch set 5 for main to change 85101 01/13/25, 11:50
-
Christian Kuhn changed Related to #105920 01/13/25, 14:08
-
Gerrit Code Review pushed patch set 6 for main to change 85101 01/13/25, 18:10
-
Gerrit Code Review pushed patch set 7 for main to change 85101 01/13/25, 18:13
-
Gerrit Code Review pushed patch set 8 for main to change 85101 01/14/25, 09:21
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 87764 01/14/25, 17:52
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 87765 01/14/25, 17:59
-
Mathias Brodala commented and changed status
Under ReviewResolved done0 %100 % 01/14/25, 18:30Applied in changeset commit:03027a9cb4c558284289da7007c225aa42a72619.
-
Benni Mack changed status
ResolvedClosed 12/02/25, 14:33 -
Simon Schaufelberger changed Related to #110686 09/12/26, 22:54
We see the same issue by using ichhabrecht/filefill. Here it is expected that files and folders are created by parallel requests.