Review 13.4 Merged

87974[TASK] Add type hints in BackendUtility for some methods

Anja Leichsenring CR +2 V +2 Normal +62 −76 updated 01/31/25, 21:46

Commit message

Starting with `getQueryBuilderForTable()` and `getConnectionForTable()`,
type hints and return types are added to the functions and their
consumers. This is only done in cases the change is considered safe,
thus where a type error would be raised by subsequential method calls
that have the type already annotated.

As a drive by improvement, the mentioned helper methods are now used
consistently within the class and always called via `self::`, because
the class provides a static context and therefor does not require
late static binding.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Anja Leichsenring commented on patch set 1 01/31/25, 19:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/31/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73292

  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 01/31/25, 21:46

  4. Anja Leichsenring merged patch set 2 01/31/25, 21:46