Review 13.4 Merged

88284[TASK] Add index to sys_refindex for EXT:form softref_key lookup

Garvin Hicking CR +2 V +2 Easy +3 −1 updated 02/20/25, 12:43

Commit message

This patch adds another sys_refindex key for EXT:form specific
database queries like:

```
SELECT ref_uid
  FROM sys_refindex
 WHERE softref_key='formPersistenceIdentifier'
   AND ref_uid > 0;
```

which would otherwise create a full-table scan and perform bad.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Garvin Hicking commented on patch set 1 02/19/25, 20:41

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/19/25, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74414

  3. Christian Kuhn voted on patch set 1 CR -2 02/20/25, 11:01

  4. Christian Kuhn voted on patch set 1 CR 0 02/20/25, 11:08

  5. Garvin Hicking updated the commit message in patch set 2 V +1 02/20/25, 11:23

  6. core-ci voted on patch set 2 V +1 02/20/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74460

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 02/20/25, 12:42

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 02/20/25, 12:42

  9. Garvin Hicking merged patch set 3 02/20/25, 12:43