Review main Merged

88673[BUGFIX] Fix malformed delete action button closing tag

Himanshu Nitsan CR +2 V +2 Easy +1 −1 updated 03/23/25, 19:28

Commit message

The delete action button was incorrectly closed as `</a>` instead of `</button>`
due to a typo introduced in the recent AJAX removal refactoring. This caused
invalid HTML and potential JavaScript interaction issues.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Himanshu Nitsan uploaded patch set 1 03/21/25, 15:30

  2. Himanshu Nitsan commented on patch set 1 CR +1 V +1 03/21/25, 15:32

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/21/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75961

  4. Benni Mack wrote 03/21/25, 15:43

    Change destination moved from 13.4 to main
  5. Benni Mack updated the commit message in patch set 2 03/21/25, 15:43

  6. Benni Mack voted on patch set 2 CR +1 V +1 03/21/25, 15:43

  7. core-ci voted on patch set 2 V +1 03/21/25, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75963

  8. Guido Schmechel voted on patch set 2 CR +1 V +1 03/21/25, 16:29

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/21/25, 16:39

  10. Garvin Hicking merged patch set 3 03/23/25, 19:28