Issue Bug Closed

#106408Delete action button incorrectly closed as anchor tag in AJAX removal fix

Himanshu Ramavat 03/21/25, 15:22 updated 12/02/25, 14:21

Description

A typo in the delete action button HTML structure causes the element to render as an invalid anchor tag instead of a button.

$deleteAction = '<button ' . $deleteActionAttributes . '>' . $icon . '</a>'; 

Issue :
The closing tag is used instead of , resulting in a malformed HTML button. This breaks accessibility, JavaScript interactions, and may cause unexpected behavior (e.g., if the href attribute is accidentally inherited from other logic).

Reviews 2

History 25

  1. Gerrit Code Review pushed patch set 1 for 13.4 to change 88673 status New Under Review 03/21/25, 15:30

  2. Gerrit Code Review pushed patch set 2 for main to change 88673 03/21/25, 15:43

  3. Gerrit Code Review pushed patch set 1 for 13.4 to change 88674 03/21/25, 16:39

  4. Himanshu Ramavat commented and changed status Under Review Resolved done 0 % 100 % 03/23/25, 19:30

    Applied in changeset commit:e7a38c77955b2469af4198e70b9273a9f27398dc.

  5. Benni Mack changed status Resolved Closed 12/02/25, 14:21