Review 13.4 Merged

88714[TASK] Remove unneeded checks for rendering the record list search box

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/24/25, 21:12

Commit message

Having the check `$tableListHtml || !empty($this->searchTerm` prevents
the rendering of the search box if no search term is present and also
no items exist on the current page.

When using a table filter (single table view), it could be possible
that items are available in sub pages, but since the search level
selector is bound to the search box, it is impossible to change this
level and adjust the search depth.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 03/24/25, 20:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/24/25, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76182

  3. Georg Ringer voted on patch set 1 CR +2 V +2 03/24/25, 21:12

  4. Georg Ringer merged patch set 2 03/24/25, 21:12