Review 13.4 Merged

90217[BUGFIX] Support password managers to autofill new password confirmation

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 08/01/25, 09:53

Commit message

For maximum compatibility with all password managers it is suggested to
add `autocomplete="new-password"` in password changing forms both on the
new password field and on the repeating password field, see:
https://www.youtube.com/watch?v=o2wkYzu5u50&t=2297s

Please be aware that some password managers like 1Password, already
automagically fill the current `autocomplete="off"` password
confirmation field, but the builtin Google Chrome password manager
honors `autocomplete="off"` and does not autofill this field and instead
expects `autocomplete="new-password"` for "suggest password" to autofill
both fields when generating a new random password.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 08/01/25, 09:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/01/25, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82621

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 08/01/25, 09:53

  4. Benjamin Franzke merged patch set 2 08/01/25, 09:53