92104[BUGFIX] Provide user-friendly wrapper for unexpected DataHandler errors
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Rachel Foucard +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2734
Show 89 earlier messages
-
Lina Wolf uploaded patch set 1 12/11/25, 17:37
-
Lina Wolf commented on patch set 1 12/11/25, 17:40
To reproduce the error and verify the new behavior: 1. Remove `'ignorePageTypeRestriction' => true` from: typo3/sysext/styleguide/Configuration/TCA/ tx_styleguide_inline_1n_inline_1_child.php 2. Create a new "inline n1" record on a standard page. 3. Add new inline child records and attempt to save. Expected result: A user-friendly, localized error message is shown, followed by the technical details of the underlying DataHandler exception. -
Lina Wolf commented on patch set 1 12/11/25, 17:42
If we backport this, the translation has to be done by calling sL(), I am willing to change this for the backport -
core-ci voted on patch set 1 V +1 12/11/25, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92082
-
Rachel Foucard voted on patch set 1 V +1 12/11/25, 20:08
-
Georg Ringer commented on patch set 1 CR -1 12/11/25, 20:20
DataHandler.php:751doesn't belong hereDataHandler.php:3429doesn't belong here -
Christian Kuhn commented on patch set 1 12/11/25, 21:07
DataHandler.php:9051talked with lina beforehand about this: this change basically frames the 'log' message a bit differently, making them better suitable for editors. that's fine as a non-intrusive patch without overhead or other foo. i'd like to +1 when the other remarks are done. -
Lina Wolf uploaded patch set 2
CR -1V +112/12/25, 05:46 -
Lina Wolf commented on patch set 2 12/12/25, 05:46
DataHandler.php:751ReplyDoneDataHandler.php:3429ReplyDone
-
core-ci voted on patch set 2 V +1 12/12/25, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92109
-
Mathias Brodala commented on patch set 2 12/12/25, 07:56
DataHandler.php:9051Tiny nitpick: the DataHandler API is not bound to forms, these messages will also occur in other contexts like own modules or CLI. So there should be another domain but "form" here. -
Lina Wolf commented on patch set 2 12/12/25, 07:59
DataHandler.php:9051ReplyNote this is `core.form`, not `EXT:form`. `core.form` contains all backend form / TCA related strings like default palette names etc. It already exists. -
Mathias Brodala commented on patch set 2 12/12/25, 08:09
DataHandler.php:9051ReplyYes, but what I wrote still holds true. DataHandler is not bound to forms, even though it is mostly used like this. See e.g. External Import. But I won't insist, this is really a micro nitpick. -
Oliver Klee updated the commit message in patch set 3
V +112/12/25, 08:10 -
Lina Wolf commented on patch set 3 12/12/25, 08:16
DataHandler.php:9051ReplyWhen the datahandler is not used with a a form, who would display the flash message? I think in an import scenario the message would get logged but never displayed. -
core-ci voted on patch set 3 V +1 12/12/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92113
-
Lina Wolf uploaded patch set 4
V +112/12/25, 08:25 -
Lina Wolf commented on patch set 3 12/12/25, 08:27
DataHandler.php:9051ReplyI gave it another look and there are more datahandler specific labels (and more yet to come in the future) so I moved the label to `data_handler.xlf` -
core-ci voted on patch set 4 V -1 12/12/25, 08:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92114
-
Lina Wolf uploaded patch set 5
V -112/12/25, 11:13 -
Lina Wolf uploaded patch set 6 12/12/25, 11:14
-
Christian Kuhn voted on patch set 6 CR +1 12/12/25, 11:24
-
core-ci voted on patch set 5 V -1 12/12/25, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92130
-
core-ci voted on patch set 6 V -1 12/12/25, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92131
-
Lina Wolf updated the commit message in patch set 7
CR +1V -112/12/25, 11:28 -
core-ci voted on patch set 7 V +1 12/12/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92135
-
Christian Kuhn voted on patch set 7 CR +1 V +1 12/12/25, 12:01
-
Rachel Foucard voted on patch set 7 V +1 12/12/25, 13:06
-
Garvin Hicking voted on patch set 7 CR +1 V +1 12/12/25, 14:29
-
Christian Kuhn voted on patch set 7 CR +2 V +2 12/12/25, 14:48
-
Christian Kuhn merged patch set 8 12/12/25, 14:52
-
Josef Glatz commented on patch set 8 12/12/25, 15:56
Is it common to use a semicolon „;“ instead of a „.“? -
Garvin Hicking commented on patch set 8 12/12/25, 16:25
Reply
it's unleast not uncommon; I haven't check the codebase though. A semicolon is used here because two independent clauses are being linked in a single sentence. “This action could not be completed” is a complete sentence, and “please contact your administrator” is another. The semicolon separates them while signalling that the second clause follows directly as a related instruction. -
Josef Glatz commented on patch set 8 12/12/25, 17:24
Reply
ACK. Asked bebaute of german translation