Review 13.4 Merged

92225[TASK] Rename $hash to $hashAlgorithm

Christian Kuhn CR +2 V +2 Easy +6 −6 updated 12/24/25, 16:42

Commit message

The variable $hash in some ResourceStorage method signatures does
not mean "$hash" but "$hashAlgorithm", which is slightly confusing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Christian Kuhn uploaded patch set 1 12/24/25, 16:14

  2. Christian Kuhn uploaded patch set 2 12/24/25, 16:16

  3. core-ci voted on patch set 1 V -1 12/24/25, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92664

  4. core-ci voted on patch set 2 V +1 12/24/25, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92665

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 12/24/25, 16:42

  6. Christian Kuhn merged patch set 3 12/24/25, 16:42