Issue Task Closed

#108566ResourceStorage: $hash sometimes means $hashAlgorithm

Christian Weiske 12/23/25, 07:34 updated 03/31/26, 08:59

Description

The variable $hash in the following ResourceStorage method signatures does not mean $hash but $hashAlgorithm:

public function hashFile(FileInterface $fileObject, string $hash): string
public function hashFileByIdentifier(string $fileIdentifier, string $hash): string

This is slightly confusing, especially when it is overridden with a real hash:

    public function hashFileByIdentifier(string $fileIdentifier, string $hash): string
    {
        $hash = $this->driver->hash($fileIdentifier, $hash);

Reviews 2

History 25

  1. Gerrit Code Review pushed patch set 1 for main to change 92212 status New Under Review 12/23/25, 07:38

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 92225 12/24/25, 16:14

  3. Gerrit Code Review pushed patch set 2 for 13.4 to change 92225 12/24/25, 16:16

  4. Anonymous commented and changed status Under Review Resolved done 0 % 100 % 12/24/25, 16:45

    Applied in changeset commit:fddec31330f196d42f8128f31749804c1324050a.

  5. Benni Mack changed status Resolved Closed 03/31/26, 08:59