Review 14.3 Merged

94918[TASK] GifBuilder: Remove reference marker for `GdImage` parameters

Andreas Kienast CR +2 V +2 Easy +23 −23 updated 07/24/26, 07:17

Commit message

Methods in the GifBuilder receive instances of `GdImage`, which are
always references by design in PHP. Therefore, the reference markers
(`&`) can be removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 07/24/26, 07:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/24/26, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105293

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 07/24/26, 07:17

  4. Andreas Kienast merged patch set 2 07/24/26, 07:17