Review 14.3 Merged

95044[TASK] Add functional tests for user authentication chain

Benni Mack CR +2 V +2 Hard +344 −0 updated 08/01/26, 05:36

Commit message

The central authentication logic in
AbstractUserAuthentication::checkAuthentication() is now covered
by functional tests, pinning down the current behavior of:

* the authentication service chain return code protocol, including
  the chain not being stopped for return codes between 1 and 99,
* user records provided by custom getUser services (SSO pattern),
* the request token gate aborting active logins,
* session creation, re-use on subsequent requests,
* MFA evaluation raising MfaRequiredException while keeping the
  created user session unmarked as MFA-verified.

A configurable fixture authentication service is registered through
the regular service chain registration to characterize the chain
semantics against the core authentication service.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 08/01/26, 05:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 08/01/26, 05:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105775

  3. Benni Mack commented on patch set 2 V -1 08/01/26, 05:20

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 08/01/26, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105776

  5. Benni Mack voted on patch set 2 CR +2 V +2 08/01/26, 05:36

  6. Benni Mack merged patch set 3 08/01/26, 05:36