Review 14.3 Merged

96079[BUGFIX] Cut indexed words by characters instead of bytes

Benni Mack CR +2 V +2 Easy +13 −1 updated 09/25/26, 16:18

Commit message

Indexer->analyzeBody() shortens words to 60 characters, the length of
the index_words.baseword field, with substr(). This works on bytes, so
words with multi-byte characters are cut in the middle of a character
and the word id is calculated from an invalid string. The analysis of
the header information already uses mb_substr().

Use mb_substr() for the body as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack commented on patch set 1 09/25/26, 15:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php
  2. Benni Mack commented on patch set 2 09/25/26, 15:40

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/25/26, 15:40

  4. core-ci voted on patch set 1 V -1 09/25/26, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109261

  5. core-ci voted on patch set 2 V -1 09/25/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109262

  6. Benni Mack abandoned the change 09/25/26, 15:55

  7. Benni Mack restored the change 09/25/26, 15:55

  8. Benni Mack uploaded patch set 3 V -1 09/25/26, 16:06

  9. core-ci voted on patch set 3 V +1 09/25/26, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109267

  10. Benni Mack voted on patch set 3 CR +2 V +2 09/25/26, 16:18

  11. Benni Mack merged patch set 4 09/25/26, 16:18