Review 14.3 Merged

96521[BUGFIX] Respect abort override in pre-commit hook

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 10/08/26, 07:58

Commit message

The pre-commit hook reads TYPO3_GIT_HOOK_ABORT_ON_ERROR only when the
variable is unset, because the check used -z instead of -n. Setting it
to "yes" therefore never aborted a commit on CGL or file header errors,
and leaving it unset cleared the "no" default.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 10/08/26, 07:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/08/26, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110467

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 10/08/26, 07:58

  4. Garvin Hicking merged patch set 2 10/08/26, 07:58