Review 14.3 Merged

96943[BUGFIX] Report malformed site set definitions as invalid sets

Oli Bartsch CR +2 V +2 Normal +75 −3 updated 10/20/26, 18:25

Commit message

A config.yaml of a site set that is no mapping, or whose name is no
string, ran into a TypeError instead of an InvalidSetException. The
error escaped the set collection and broke building the set registry
as a whole, instead of disabling the one broken set.

Both are now checked right after the file is parsed, and reported
with the file they occur in. For sets without a usable name, the
file also identifies the error, so all malformed sets can be
reported together.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Oli Bartsch commented on patch set 1 10/20/26, 16:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/20/26, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111882

  3. Oli Bartsch uploaded patch set 2 V -1 10/20/26, 16:37

  4. core-ci voted on patch set 2 V +1 10/20/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111891

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 10/20/26, 18:25

  6. Oli Bartsch merged patch set 3 10/20/26, 18:25