Review 14.3 Merged

97182[BUGFIX] Prevent ambiguous column reference in menu_categorized_content

Garvin Hicking CR +2 V +2 Normal +124 −2 updated 10/28/26, 09:21

Commit message

The query of the "Categorized content" element joins
sys_category_record_mm, but referenced its columns `tablenames`,
`fieldname` and the tt_content `uid` without a table name. As soon
as tt_content has a column `tablenames` or `fieldname` (e.g. inline
fields using foreign_table_field), or sys_category_record_mm gets a
`uid` column, the query fails with an ambiguous column error.

All these columns are now qualified with their table.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 58

  1. Garvin Hicking commented on patch set 1 10/27/26, 22:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/27/26, 22:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112667

  3. Garvin Hicking commented on patch set 2 V -1 10/27/26, 23:08

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 10/27/26, 23:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112668

  5. Garvin Hicking commented on patch set 3 V -1 10/28/26, 08:43

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 10/28/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112687

  7. Garvin Hicking voted on patch set 3 CR +2 V +2 10/28/26, 09:20

  8. Garvin Hicking merged patch set 4 10/28/26, 09:21