Issue Feature Closed

#105007Indexed Search - removed searchSkipExtendToSubpagesChecking can't be migrated

B. Kausch 09/17/24, 13:13 updated 12/02/25, 14:33

Description

The option searchSkipExtendToSubpagesChecking was removed in #97530. This decision was a nightmare for our very big typo3 sites. With 5000+ pages this removed option has serious performance penalties. Every search request will now create a page tree with many database queries. One request can take up to 10 seconds. The migration path described here is just: “If you still encounter using indexed search related to extendToSubpages it is recommended to extend Indexed Search queries with custom hooks to manipulate the search query.”

But the hook is not equipped to replace the old functionality. In v12 it was not given the query builder to give fine granular control and in v13 the hook was removed completly in #102937. What do we now? We need a hook to manipulate the search query for big typo3 sites.

Reviews 4

History 1127

Show 2 earlier messages
  1. Georg Ringer commented <span data-processor="relativetime" data-value="2024-09-17T18:44:53+00:00" > 09/17/24, 18:44 </span>

    hey!
    thanks for your issue! can you suggest places for events which would make sense for you?

  2. B. Kausch commented <span data-processor="relativetime" data-value="2024-09-18T11:06:27+00:00" > 09/18/24, 11:06 </span>

    Well, my suggestion would be these spots:

    https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L548
    https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L1008

    It is before the query is executed and if the hook would expose the QueryBuilder instance every integrator would have the most freedom to change the search behavior. You combine that with an rootPidList=-1 to disable the very extensive building of the page tree this hook could meet any needs.

  3. Gerrit Code Review pushed patch set 1 for main to change 86593 status Accepted Under Review <span data-processor="relativetime" data-value="2024-10-15T07:20:22+00:00" > 10/15/24, 07:20 </span>

  4. Oliver Bartsch commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2024-10-18T17:15:07+00:00" > 10/18/24, 17:15 </span>

    Applied in changeset commit:a331b40ba33ee0448fd1c5852a83e4d756e82818.

  5. Gerrit Code Review pushed patch set 2 for 13.4 to change 86616 status Resolved Under Review <span data-processor="relativetime" data-value="2024-10-19T17:29:53+00:00" > 10/19/24, 17:29 </span>

  6. Oliver Bartsch commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2024-10-19T17:40:07+00:00" > 10/19/24, 17:40 </span>

    Applied in changeset commit:4d48fc427bcbe67e46c63c2415a492de232bd771.