#105007Indexed Search - removed searchSkipExtendToSubpagesChecking can't be migrated
Description
The option searchSkipExtendToSubpagesChecking was removed in #97530. This decision was a nightmare for our very big typo3 sites. With 5000+ pages this removed option has serious performance penalties. Every search request will now create a page tree with many database queries. One request can take up to 10 seconds. The migration path described here is just: “If you still encounter using indexed search related to extendToSubpages it is recommended to extend Indexed Search queries with custom hooks to manipulate the search query.”
But the hook is not equipped to replace the old functionality. In v12 it was not given the query builder to give fine granular control and in v13 the hook was removed completly in #102937. What do we now? We need a hook to manipulate the search query for big typo3 sites.
Reviews 4
Related issues 2
History 1127
Show 2 earlier messages
-
Georg Ringer changed Related to #97530 <span data-processor="relativetime" data-value="2024-09-17T18:43:31+00:00" > 09/17/24, 18:43 </span>
-
Georg Ringer changed Related to #102937 <span data-processor="relativetime" data-value="2024-09-17T18:43:39+00:00" > 09/17/24, 18:43 </span>
-
Georg Ringer changed status
NewAccepted <span data-processor="relativetime" data-value="2024-09-17T18:45:05+00:00" > 09/17/24, 18:45 </span> -
B. Kausch commented <span data-processor="relativetime" data-value="2024-09-18T11:06:27+00:00" > 09/18/24, 11:06 </span>
Well, my suggestion would be these spots:
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L548
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L1008It is before the query is executed and if the hook would expose the QueryBuilder instance every integrator would have the most freedom to change the search behavior. You combine that with an
rootPidList=-1to disable the very extensive building of the page tree this hook could meet any needs. -
Benni Mack commented <span data-processor="relativetime" data-value="2024-10-04T20:33:11+00:00" > 10/04/24, 20:33 </span>
The two changes we need to look at:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/74377
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/82653 -
Gerrit Code Review pushed patch set 1 for main to change 86593 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2024-10-15T07:20:22+00:00" > 10/15/24, 07:20 </span> -
Gerrit Code Review pushed patch set 2 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T07:20:38+00:00" > 10/15/24, 07:20 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T07:22:19+00:00" > 10/15/24, 07:22 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T07:35:20+00:00" > 10/15/24, 07:35 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T08:49:24+00:00" > 10/15/24, 08:49 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T08:51:08+00:00" > 10/15/24, 08:51 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T09:00:19+00:00" > 10/15/24, 09:00 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-15T09:26:29+00:00" > 10/15/24, 09:26 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2024-10-15T09:46:23+00:00" > 10/15/24, 09:46 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-16T06:53:34+00:00" > 10/16/24, 06:53 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-16T18:26:10+00:00" > 10/16/24, 18:26 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-16T18:27:15+00:00" > 10/16/24, 18:27 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-18T10:05:13+00:00" > 10/18/24, 10:05 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-18T12:21:52+00:00" > 10/18/24, 12:21 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 86593 <span data-processor="relativetime" data-value="2024-10-18T13:34:26+00:00" > 10/18/24, 13:34 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 86616 <span data-processor="relativetime" data-value="2024-10-18T17:10:28+00:00" > 10/18/24, 17:10 </span>
-
Oliver Bartsch commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2024-10-18T17:15:07+00:00" > 10/18/24, 17:15 </span>Applied in changeset commit:a331b40ba33ee0448fd1c5852a83e4d756e82818.
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 86616 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2024-10-19T17:29:53+00:00" > 10/19/24, 17:29 </span> -
Oliver Bartsch commented and changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2024-10-19T17:40:07+00:00" > 10/19/24, 17:40 </span>Applied in changeset commit:4d48fc427bcbe67e46c63c2415a492de232bd771.
-
Lina Wolf commented <span data-processor="relativetime" data-value="2024-11-30T12:27:42+00:00" > 11/30/24, 12:27 </span>
Related documentation changes need to be reviewed: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/5111
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:33:29+00:00" > 12/02/25, 14:33 </span>
hey!
thanks for your issue! can you suggest places for events which would make sense for you?