Issue Bug Resolved

#95714Omit attributes with blank values for additionalAttributes in VideoTagRenderer

Christian Toffolo 10/20/21, 09:51 updated 09/04/26, 07:55

Description

VideoTagRenderer.php implodes attributes with $dontOmitBlankAttribs = true.

$attributes[] = GeneralUtility::implodeAttributes($options['additionalAttributes'], true, true);

This could create problems like in this use case:

Example:

<f:media ... additionalAttributes="{poster: '{v:media.exists(file: \'fileadmin/test.jpg\', then: \'/fileadmin/test.jpg\')}', no-cookie: 1, relatedVideos: 0, color: 'white', playsinline: '1'}" />

In this case, AFAIK, it’s not possible to omit the attribute ‘poster’ in Fluid. So, if file doesn’t exist the attribute will still be present with an empty value but the use case wants that if a poster is not available for the video then the attribute must not be present.

I don’t know if there are use cases that needs $dontOmitBlankAttribs = true but I think that it should be false.

Reviews 3

History 412

  1. Oliver Hader commented 10/20/21, 13:28

    Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/53488/, issue #81741
    (it probably affects some more classes, not only VideoTagRenderer)

  2. Oliver Hader changed Related to #81741 10/20/21, 13:28

  3. Gerrit Code Review pushed patch set 1 for main to change 84625 status New Under Review 06/11/24, 18:50

  4. Gerrit Code Review pushed patch set 2 for main to change 84625 06/11/24, 18:57

  5. Gerrit Code Review pushed patch set 3 for main to change 84625 10/18/24, 13:36

  6. Benni Mack changed Related to #102392 04/11/25, 22:20

  7. Gerrit Code Review pushed patch set 4 for main to change 84625 04/22/26, 06:50

  8. Gerrit Code Review pushed patch set 5 for main to change 84625 09/03/26, 18:17

  9. Gerrit Code Review pushed patch set 1 for 14.3 to change 95628 09/04/26, 06:48

  10. Gerrit Code Review pushed patch set 6 for main to change 84625 09/04/26, 06:49

  11. Gerrit Code Review pushed patch set 2 for 14.3 to change 95628 09/04/26, 06:49

  12. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 09/04/26, 07:55

    Applied in changeset commit:f6d7f90c0c7a8d3e94a19c73596c7de3ee456519.