1005[TASK] Utilize hook_previewinfo to show the preview info
Commit message
Review
-
Code review CR +2
- Susi Moog +2
-
Verified V +2
- Susi Moog +2
Files 2
Review log 14
-
Gerrit wrote 03/28/11, 20:01
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Tolleiv Nietsch uploaded patch set 2 03/28/11, 20:01
-
Tolleiv Nietsch uploaded patch set 3 03/28/11, 20:01
-
Tolleiv Nietsch commented on patch set 3 03/28/11, 20:01
Hi - well using the hook enables other to replace this without XCLASSes - it's not executed on every page request - the hooks are only triggered if fePreview != 0 (see https://review.typo3.org/#change,1003) -
Francois Suter commented on patch set 3 03/28/11, 20:01
Verified; Looks good to me, but someone else must approve Works as expected. Preview info still appears when needed. -
Dmitry Dulepov commented on patch set 1 03/28/11, 20:01
I would prefer that you didn't submit this First of all, why do you need to use a hook to tslib inside tslib? Just add it to the index_ts.php as admin panel does. Calling a hook is not cheap: it is resolving a class name + a dynamic call using call_user_func. There is no need to slow down TYPO3 if you can avoid it :) Secondly, the proposed way would create invalid markup. This is what we try to get rid of since 4.4.x. Please, use techniques like shown in the index_ts.php for the admin panel: ...->content = str_ireplace('</body>', $yourContent . '</body>', ...->content) -
Dmitry Dulepov commented on patch set 3 03/28/11, 20:01
I would prefer that you didn't submit this I still do not see why we need to use a hook inside tslib. Why don't you simply add it to index_ts.php as admin panel does? Every hook only slowers down the whole system. This preview hook will be executed on EVERY page request and slow down EVERY page view (cached or uncached). I see no reason to use a hook here. This can be easily done in the code without hooks. Hooks are for external code. Having a hook in tslib to tslib does not look right. -
Dmitry Dulepov commented on patch set 3 03/28/11, 20:01
No score Ok, thanks. No -1 anymore. Btw, according to coding guidelines that piece of code should changed. I'll comment there. -
Susi Moog commented on patch set 3 03/28/11, 20:01
Looks good to me, but someone else must approve In general the way it's done is ok for me, but would you please write some comment about the change between patchset 1 and 3 (or answer Dmitrys post) - this is very confusing without comments. -
Susi Moog commented on patch set 3 V 0 03/28/11, 20:01
by team member; Looks good to me, approved -
Susi Moog uploaded patch set 4 03/28/11, 20:01
-
Susi Moog commented on patch set 4 V 0 03/28/11, 20:01
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 4 03/28/11, 20:01
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/129/ -
Susi Moog merged patch set 4 03/28/11, 20:01