Review main Abandoned

1006[BUGFIX] No image generation with PHP-SAFE_MODE (GM/IM)

Jigal van Hemert CR 0 V 0 Easy +39 −2 updated 06/03/13, 20:49

Commit message

With PHP in SAFE_MODE all imagemagick/graphicsmagick calls will fail. To
support paths with whitespace characters quotes are added (using
escapeshellarg()). With safe_mode enabled PHP executes escapeshellcmd()
on the entire command. Now the quotes will be escaped and the command
will fail.
This patch changes that escapeshellarg is only if it is useful (i.e. if
there are whitespace characters or if characters were escaped).

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 3