10082[BUGFIX] Localize command must preserve type
Commit message
Review
-
Code review CR +2
- Francois Suter +2
- Andreas Otto +1
- Helmut Hummel +1
-
Verified V +2
- Francois Suter +2
- Andreas Otto +1
- Helmut Hummel +1
Files 1
Review log 8
-
Andreas Otto commented on patch set 1 04/23/12, 06:52
Verified; Looks good to me, but someone else must approve Thanks for this easy fix Francois. -
Tolleiv Nietsch commented on patch set 1 04/23/12, 06:52
Unit test? -
Francois Suter commented on patch set 1 04/23/12, 06:52
Hi Tolleiv, I thought about it, but it's beyond my current skills in unit tests, I'm afraid. I checked what exists and there's not a single test yet for TCEmain that creates records, I've never done that before. If you can help me, then gladly. Otherwise I really don't have the time now for such a simple bug fix. -
Helmut Hummel commented on patch set 1 04/23/12, 06:52
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 04/23/12, 06:52
I suggest adding unit tests as a seperate issue, but maybe the slides (second half) about testing framework feature of ext:phpunit are of help? http://www.slideshare.net/oliverklee/testdriven-development-for-typo3-12541044 -
Mr. Jenkins commented on patch set 1 04/23/12, 06:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3691/ : SUCCESS -
Francois Suter commented on patch set 1 V 0 04/23/12, 06:52
by team member; Looks good to me, approved Philipp, that's what I was thinking about. -
Francois Suter merged patch set 1 04/23/12, 06:52