10107[BUGFIX] displayCondition on FlexForm Sheets broken
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Dominik Mathern +1
- Jigal van Hemert +1
-
Verified V +2
- Steffen Ritter +2
- Dominik Mathern +1
- Jigal van Hemert +1
Files 1
Review log 6
-
Steffen Ritter merged patch set 1 04/05/12, 09:48
-
Steffen Ritter commented on patch set 2 V 0 04/05/12, 09:48
by team member; Looks good to me, approved -
Jigal van Hemert uploaded patch set 2 04/05/12, 09:48
-
Jigal van Hemert commented on patch set 2 04/05/12, 09:48
Verified; Looks good to me, but someone else must approve $lang variable was defined a bit later in the code, moving that line solves the bug and makes the code more consistent. Good catch! -
Dominik Mathern commented on patch set 2 04/05/12, 09:48
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 04/05/12, 09:48
What about master?