Review TYPO3_4-7 Merged

10107[BUGFIX] displayCondition on FlexForm Sheets broken

Steffen Ritter CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

Due to the usage of an undefined variable, the value of
an field within the flexform cannot resolved correctly.
As an result any displayCondition of an FlexForm sheet looking
at a field value (FIELD:*:=:value) evaluates to false.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Dominik Mathern +1
    • Jigal van Hemert +1
  • Verified V +2
    • Steffen Ritter +2
    • Dominik Mathern +1
    • Jigal van Hemert +1

Files 1

Review log 6

  1. Steffen Ritter merged patch set 1 04/05/12, 09:48

  2. Steffen Ritter commented on patch set 2 V 0 04/05/12, 09:48

    by team member; Looks good to me, approved
  3. Jigal van Hemert uploaded patch set 2 04/05/12, 09:48

  4. Jigal van Hemert commented on patch set 2 04/05/12, 09:48

    Verified; Looks good to me, but someone else must approve $lang variable was defined a bit later in the code, moving that line solves the bug and makes the code more consistent. Good catch!
  5. Dominik Mathern commented on patch set 2 04/05/12, 09:48

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 2 04/05/12, 09:48

    What about master?