Review TYPO3_4-7 Merged

10109[BUGFIX] Improve usability of new Media element flexform

Steffen Ritter CR +2 V +2 Hard +229 −195 updated 06/03/13, 20:49

Commit message

With HTML5 video many new options are added to the media element
flexform. This results in a very hard to read form.

Restructure the fields into tabs and use display conditions
to hide unneeded fields depending on the selected media type.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Markus Klein +1
    • Dominik Mathern +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1
    • Dominik Mathern +1

Files 3

Review log 11

  1. Steffen Ritter uploaded patch set 2 04/10/12, 12:45

  2. Oliver Klee commented on patch set 3 04/10/12, 12:45

    (4 inline comments) Going to push an updated patch in a minute.

    flexform_media.xml:40

    This should be "num" instead of "int" so no negative numbers can be entered.

    flexform_media.xml:51

    Ditto.

    locallang_ttc.xlf:829

    This should be without the hyphen.

    locallang_ttc.xlf:832

    Ditto.
  3. Markus Klein commented on patch set 4 04/10/12, 12:45

    Verified; Looks good to me, but someone else must approve
  4. Oliver Klee uploaded patch set 4 04/10/12, 12:45

  5. Steffen Ritter uploaded patch set 3 04/10/12, 12:45

  6. Steffen Ritter commented on patch set 3 04/10/12, 12:45

    just removed dependencies
  7. Steffen Ritter commented on patch set 4 V 0 04/10/12, 12:45

    by team member; Looks good to me, approved
  8. Steffen Ritter merged patch set 4 04/10/12, 12:45

  9. Jigal van Hemert commented on patch set 2 04/10/12, 12:45

    Verified; Looks good to me, but someone else must approve
  10. Dominik Mathern commented on patch set 4 04/10/12, 12:45

    Verified; Looks good to me, but someone else must approve
  11. Philipp Gampe commented on patch set 4 04/10/12, 12:45

    This needs to be ported/pushed to master!