Review main Merged

1013[TASK] Remove t3lib_sqlengine

Georg Ringer CR -1 V +1 Hard +0 −894 updated 06/03/13, 20:49

Commit message

t3lib_sqlengine is deprecated, remove it

Review

  • Code review CR -1
    • Steffen Kamper +2
    • Björn Pedersen +1
    • Oliver Klee +1
    • Dmitry Dulepov -1
    • Xavier Perseguers +1
  • Verified V +1
    • Steffen Kamper +1

Files 1

Review log 11

  1. Andreas Wolf commented on patch set 1 03/21/11, 21:47

    There is a ticket now and Georg also made a new change request incorporating Dmitrys suggestions. So, Dmitry and Xavier: are your concerns still valid or is this one ready to commit?
  2. Andreas Wolf commented on patch set 1 03/21/11, 21:47

    There is a ticket now and Georg also made a new change request incorporating Dmitrys suggestions. So, Dmitry and Xavier: are your concerns still valid or is this one ready to commit?
  3. Andreas Wolf commented on patch set 1 03/21/11, 21:47

    I also didn't "test" (also wouldn't know how to), but as there are no references left in Core, we can be pretty sure that it doesn't break anything.
  4. Björn Pedersen commented on patch set 1 03/21/11, 21:47

    Looks good to me, but someone else must approve @Dimitry: core_autoload states that it should not be touched by hand. Does this still apply, else the comment should definitly be changed.
  5. Dmitry Dulepov commented on patch set 1 03/21/11, 21:47

    I would prefer that you didn't submit this Classes from the deleted file are still =referenced by the autoloader (t3lib/core_autoload.php: t3lib_sqlengine and t3lib_sqlengine_resultobj). Also typo3/sysext/em/classes/database/class.tx_em_database.php refers to this class in comment. It would be good if you could change that too, so we do not have dead refs even in comments. Thanks!
  6. Dmitry Dulepov commented on patch set 1 03/21/11, 21:47

    Hm, I do not see a change request that removes references to this class in t3lib/core_autoloader.php
  7. Oliver Klee commented on patch set 1 03/21/11, 21:47

    Looks good to me, but someone else must approve Code removal, yummy!
  8. Steffen Kamper commented on patch set 1 03/21/11, 21:47

    Verified; Looks good to me, approved
  9. Xavier Perseguers commented on patch set 1 03/21/11, 21:47

    I would prefer that you didn't submit this This should be synchronized with DBAL too as there is an XCLASS there. As with Dmitry's comment, if all references are removed, then it's OK.
  10. Xavier Perseguers commented on patch set 1 03/21/11, 21:47

    Looks good to me, but someone else must approve Sorry, did not test but as there is a corresponding change for DBAL, I'm fine now.
  11. Steffen Kamper merged patch set 1 03/21/11, 21:47