Review main Abandoned

1019[BUGFIX] Labels of colPos in the list view don't match Grid View

Jo Hasenau CR 0 V 0 Normal +67 −23 updated 06/03/13, 20:49

Commit message

Same thing for editing forms

Both of them don't match the labels that have been defined in the Grid
record currently used by the page.
Fixes depend on each, so joining them in one commit.

Fixes: #M17525, #M17682, #M17741 and #M17745

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 22

  1. Peter Niederlag commented on patch set 1 07/15/11, 13:02

    (3 inline comments) phpdoc. accessing array element(?), any performance impacts(?) of passing around an additional potential large array (row) for example in listView?

    class.t3lib_befunc.php:1990

    phpdoc for newly introduced param is missing

    class.t3lib_befunc.php:1999

    acessing a nested element might need checks(see below), not sure here

    class.t3lib_befunc.php:2156

    phpdoc
  2. Stefan Neufeind commented on patch set 2 07/15/11, 13:02

    Just rolloed small fixes from comments and some CGL-issues I stumbled across.
  3. Stefan Neufeind commented on patch set 3 07/15/11, 13:02

    Seems to just fail for Mr. Jenkins I guess ...
  4. Stefan Neufeind commented on patch set 3 07/15/11, 13:02

    Steffen, could you have another look please? CGL-comments were merged and you tested already the rest works fine.
  5. Stefan Neufeind uploaded patch set 3 07/15/11, 13:02

  6. Julian Hofmann commented on patch set 2 3 comments 07/15/11, 13:02

    I would prefer that you didn't submit this Wrong datatypes could effect errors - maybe not today, but in future
  7. Steffen Ritter commented on patch set 2 07/15/11, 13:02

    Verified; I would prefer that you didn't submit this Hi Joey, pach works as you want it to :) But: CGL is not matched... See my inline-comments

    class.tx_cms_backendlayout.php:93

    please indent comments with one tab... add one space after if

    class.tx_cms_backendlayout.php:106

    empty lines shouldnt have indention space problem on if a line below

    class.tx_cms_backendlayout.php:111

    if ( misses space I would like to have an strict !==

    class.tx_cms_layout.php:636

    would like to have strict comparism here, too
  8. Philipp Gampe commented on patch set 4 07/15/11, 13:02

    Verified; Looks good to me, but someone else must approve Works fine. I just did a rebase and change all $TCA to $GLOBALS['TCA']
  9. Philipp Gampe uploaded patch set 4 07/15/11, 13:02

  10. Stefan Neufeind commented on patch set 5 8 comments 07/15/11, 13:02

    Looks good to me, but someone else must approve looks okay. just some nitpicks and missing phpdoc-blocks. so this is a conditional +1 actually
  11. Stefan Neufeind commented on patch set 5 07/15/11, 13:02

    No score A test? I'd have to look deeper in the referenced bugs etc. to find out about the background - but I also see them open. You mean it "doesn't work"? Or is there a another commit (change-id) in parallel? Or what?
  12. Xavier Perseguers commented on patch set 5 07/15/11, 13:02

    "Anonymous coward" should abandone it...
  13. Xavier Perseguers commented on patch set 5 07/15/11, 13:02

    Fails; Do not submit
  14. Steffen Ritter commented on patch set 5 07/15/11, 13:02

    Looks good to me, approved
  15. Philipp Gampe uploaded patch set 5 07/15/11, 13:02

  16. Philipp Gampe commented on patch set 5 07/15/11, 13:02

    Verified; Looks good to me, but someone else must approve renewing my vote, just fixed another CGL issue spottet by jenkins
  17. Jo Hasenau uploaded patch set 2 07/15/11, 13:02

  18. Jo Hasenau commented on patch set 5 07/15/11, 13:02

    Fails; I would prefer that you didn't submit this Can someone please close this one, since it's been a test during the code sprint in Berlin.
  19. Mr. Jenkins commented on patch set 3 07/15/11, 13:02

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/697/ : FAILURE
  20. Mr. Jenkins commented on patch set 4 07/15/11, 13:02

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/883/ : FAILURE
  21. Mr. Jenkins commented on patch set 5 07/15/11, 13:02

  22. Peter Niederlag commented on patch set 5 07/15/11, 13:02

    Abandoned obsolete/test request