Review main Merged

10200[BUGFIX] rsaauth PHP backend calls key generation on every request

Daniel Poetzinger CR +2 V +2 Easy +7 −4 updated 06/03/13, 20:49

Commit message

Problem: openssl_pkey_new is not a simple cheap operation and 
for minimal requests (e.g. ajax), this can consume up to 10% of the request time.

Solution: Do not process the login fields if no login is triggered.

This commit will save even more processing power as the whole service chain
for processing the login fields is not instantiated anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 1