10356[BUGFIX] VariableFrontend initializeObject not called
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Files 2
Review log 17
-
Markus Klein commented on patch set 1 06/30/12, 11:59
I would prefer that you didn't submit this Please follow the commit message guide! -
Tolleiv Nietsch uploaded patch set 3 06/30/12, 11:59
-
Tolleiv Nietsch commented on patch set 3 06/30/12, 11:59
Verified; Looks good to me, but someone else must approve Added the other branches - thx for the hint Stefan -
Stefan Neufeind commented on patch set 2 06/30/12, 11:59
Looks good to me, but someone else must approve It already is public in other cache-frontends, so that's the correct way. Please adjust releases-line in commit-msg before commit.Was added with 4.5, so please make this: 4.5, 4.6, 4.7, 6.0 -
Stefan Neufeind commented on patch set 3 06/30/12, 11:59
Looks good to me, but someone else must approve reapplying vote -
Markus Klein uploaded patch set 2 06/30/12, 11:59
-
Christian Kuhn commented on patch set 3 06/30/12, 11:59
I would prefer that you didn't submit this The patch is clearly correct. But currently, the according tests fail if IgBinary is available. A quick check of the current version of FLOW3 cache framework shows that the tests work there (and the initializeObject() method is public there as well). Thus, I think it would be better if we first fix the unit tests, maybe together with this patch here. BTW: The current status of the cache framework from FLOW3 should be back ported to 6.0 anyway before release. -
Christian Kuhn uploaded patch set 4 06/30/12, 11:59
-
Christian Kuhn commented on patch set 4 V 0 06/30/12, 11:59
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 4 06/30/12, 11:59
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 06/30/12, 11:59
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 06/30/12, 11:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3982/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/30/12, 11:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4646/ : SUCCESS -
Kilian Hann commented on patch set 1 06/30/12, 11:59
Looks good to me, but someone else must approve -
Kilian Hann commented on patch set 2 06/30/12, 11:59
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 4 06/30/12, 11:59
Verified; Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 4 06/30/12, 11:59