1037[FEATURE] pagetree dataprovider should enable node postprocessing
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Susi Moog +2
-
Verified V +2
- Susi Moog +2
- Georg Ringer +1
Issues 1
Files 3
Review log 25
-
Ernesto Baschny commented on patch set 2 07/09/11, 09:33
Looks good to me, but someone else must approve Please document the methods of the interface with some more information before committing.interface.t3lib_tree_pagetree_interfaces_collectionprocessor.php:38I would appreciate if you could add some documentation to these methods, explaining when exactly they are called and giving some information about what can be manipulated here (or not). Same applies to the other three methods below. -
Ernesto Baschny commented on patch set 2 07/09/11, 09:33
@Tolleiv, yes, it is ok :) -
Tolleiv Nietsch uploaded patch set 2 07/09/11, 09:33
-
Tolleiv Nietsch commented on patch set 2 07/09/11, 09:33
Ernesto is it ok for you to add these hooks also to 4.5 ? I will add the documentation of course. -
Tolleiv Nietsch uploaded patch set 3 07/09/11, 09:33
-
Tolleiv Nietsch commented on patch set 3 07/09/11, 09:33
(1 inline comment) -
Sonja Schubert commented on patch set 2 07/09/11, 09:33
Verified; Looks good to me, but someone else must approve -
Björn Pedersen commented on patch set 2 07/09/11, 09:33
Looks good to me, but someone else must approve -
Björn Pedersen commented on patch set 2 07/09/11, 09:33
@Simon: Are you sure this patch is the source of your problem? To me it looks like a workspace problem, where CE changes on a page are not propagated to the page tree. -
Stefan Neufeind commented on patch set 2 07/09/11, 09:33
Looks good to me, but someone else must approve Only minor additions needed, looks good. Would be nice to have in. -
Stefan Neufeind commented on patch set 3 07/09/11, 09:33
Looks good to me, but someone else must approve -
Susi Moog uploaded patch set 4 07/09/11, 09:33
-
Susi Moog commented on patch set 4 07/09/11, 09:33
Verified; Looks good to me, but someone else must approve Only fixed the white space errors. -
Stefan Galinski commented on patch set 2 07/09/11, 09:33
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 07/09/11, 09:33
Looks good to me, but someone else must approveclass.t3lib_tree_pagetree_dataprovider.php:81is this now the behaviour: i would prefer an additional is_array instead of the type casting -
Georg Ringer commented on patch set 3 1 comment 07/09/11, 09:33
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 3 07/09/11, 09:33
(1 inline comment) -
Georg Ringer commented on patch set 4 07/09/11, 09:33
Verified; Looks good to me, approved -
Steffen Gebert commented on patch set 2 07/09/11, 09:33
I would prefer that you didn't submit thisPlease use "Resolves: #25255" -
Simon Schaufelberger commented on patch set 2 07/09/11, 09:33
Fails I tested it and for me it does not work. I have changed a content element in workspace. the ce has a green background now but the page in the pagetree still have no green background. The page in the pagetree only becomes green, if i change the page properties of the page. -
Simon Schaufelberger commented on patch set 2 07/09/11, 09:33
I am using: $GLOBALS['TBE_STYLES']['stylesheet2'] = '../fileadmin/templates/plugins/typo3_skin/add_styles.css'; in ext_tables.php containing: #typo3-alt-db-navframe-php .workspace-info { margin: 10px 0 0 10px; border: none; } #typo3-versionSelector { border: 1px solid #FF0000; background-color: #ff9999!important; background-image: url('../icons/gfx/alt_menu_mainitem_bg.gif'); background-repeat: repeat-x; } #typo3-versionSelector td { color: #FFFFFF; } #PageTreeDiv ul.tree li.active, #PageTreeDiv ul.tree ul li.active { background-color: #ffe4e1!important; } #PageTreeDiv ul.tree li.active a, #PageTreeDiv ul.tree ul li.active a { color: #FF0000; } .ver-element, UL.tree UL LI.ver-element {background-color: #ccffcc!important; } .ver-page, UL.tree UL LI.ver-page { background-color: #ff9999; } .ver-branch, UL.tree UL LI.ver-branch { background-color: #ccccff; } .ver-branchpoint, UL.tree UL LI.ver-branchpoint { background-color: #ff9999; } .ver-versions, UL.tree UL LI.ver-versions { background-color: #ffffaa;} -
Mr. Jenkins commented on patch set 3 07/09/11, 09:33
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/896/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/09/11, 09:33
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/982/ : SUCCESS -
Susi Moog commented on patch set 4 V 0 07/09/11, 09:33
by team member; Looks good to me, approved -
Susi Moog merged patch set 4 07/09/11, 09:33