Review main Merged

10425[BUGFIX] Hide the field "Selected Pages" for menu type "Sitemap"

Marco Huber CR +2 V +2 Easy +5 −1 updated 06/03/13, 20:49

Commit message

The field "Selected Pages" is never used in the content element
"Menu/Sitemap" with menu type "Sitemap". So it should not be
shown in the backend.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Stefan Galinski +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Stefan Galinski +1
    • Philipp Gampe +1

Files 2

Review log 11

  1. Markus Klein commented on patch set 1 06/13/12, 05:03

    Verified; Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 2 06/13/12, 05:03

    Verified; Looks good to me, but someone else must approve Reapplying vote
  3. Stefan Galinski uploaded patch set 2 06/13/12, 05:03

  4. Stefan Galinski commented on patch set 2 06/13/12, 05:03

    Verified; Looks good to me, but someone else must approve Just removed the 4.4 from the releases line.
  5. Georg Ringer commented on patch set 2 V 0 06/13/12, 05:03

    by team member; Looks good to me, approved
  6. Philipp Gampe commented on patch set 1 V 0 06/13/12, 05:03

    no 4.4 (security fixes only)
  7. Philipp Gampe commented on patch set 1 1 comment 06/13/12, 05:03

    Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 2 06/13/12, 05:03

    Verified; Looks good to me, but someone else must approve just reapplying
  9. Mr. Jenkins commented on patch set 2 06/13/12, 05:03

  10. Wouter Wolters commented on patch set 2 06/13/12, 05:03

    Verified; Looks good to me, but someone else must approve
  11. Georg Ringer merged patch set 2 06/13/12, 05:03