10549[BUGFIX] Description of pidSelect in class.db_list.inc is misleading
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Files 1
Review log 18
-
Tolleiv Nietsch commented on patch set 2 08/03/12, 12:13
Change request is still valid - right? -
Tolleiv Nietsch commented on patch set 2 08/03/12, 12:13
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 08/03/12, 12:13
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 2 08/03/12, 12:13
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 2 08/03/12, 12:13
-
Jo Hasenau commented on patch set 2 08/03/12, 12:13
No score Change request is still valid, and the first patchset should be OK. But the second one does not match. -
Jo Hasenau commented on patch set 2 08/03/12, 12:13
Looks good to me, but someone else must approve It did not match but now it does. :-) -
Jo Hasenau commented on patch set 2 08/03/12, 12:13
I would prefer that you didn't submit this Could it be that this patch set was meant for a completely different Change ID? ;-) -
Mr. Jenkins commented on patch set 1 08/03/12, 12:13
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3764/ : FAILURE -
Mr. Jenkins commented on patch set 2 08/03/12, 12:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3765/ : SUCCESS -
Christian Kuhn uploaded patch set 4 08/03/12, 12:13
-
Mr. Jenkins commented on patch set 3 08/03/12, 12:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4652/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/03/12, 12:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5119/ : SUCCESS -
Wouter Wolters uploaded patch set 3 08/03/12, 12:13
-
Wouter Wolters commented on patch set 3 08/03/12, 12:13
Anyone? -
Wouter Wolters commented on patch set 3 08/03/12, 12:13
Looks good to me, but someone else must approve Rebased, IMHO this one had enough votes -
Christian Kuhn commented on patch set 4 V 0 08/03/12, 12:13
by team member; Looks good to me, approved Merged. Since this is not a code bugfix, it should be ok for for 6.0 only. -
Christian Kuhn merged patch set 4 08/03/12, 12:13