Review main Merged

10549[BUGFIX] Description of pidSelect in class.db_list.inc is misleading

Jo Hasenau CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

Tell the user that this is not just a list of IDs but a query part with
the fieldname and the operator.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 18

  1. Tolleiv Nietsch commented on patch set 2 08/03/12, 12:13

    Change request is still valid - right?
  2. Tolleiv Nietsch commented on patch set 2 08/03/12, 12:13

    Verified; Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 2 08/03/12, 12:13

    Looks good to me, but someone else must approve
  4. Oliver Klee commented on patch set 2 08/03/12, 12:13

    Looks good to me, but someone else must approve
  5. Steffen Gebert uploaded patch set 2 08/03/12, 12:13

  6. Jo Hasenau commented on patch set 2 08/03/12, 12:13

    No score Change request is still valid, and the first patchset should be OK. But the second one does not match.
  7. Jo Hasenau commented on patch set 2 08/03/12, 12:13

    Looks good to me, but someone else must approve It did not match but now it does. :-)
  8. Jo Hasenau commented on patch set 2 08/03/12, 12:13

    I would prefer that you didn't submit this Could it be that this patch set was meant for a completely different Change ID? ;-)
  9. Mr. Jenkins commented on patch set 1 08/03/12, 12:13

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3764/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 08/03/12, 12:13

  11. Christian Kuhn uploaded patch set 4 08/03/12, 12:13

  12. Mr. Jenkins commented on patch set 3 08/03/12, 12:13

  13. Mr. Jenkins commented on patch set 4 08/03/12, 12:13

  14. Wouter Wolters uploaded patch set 3 08/03/12, 12:13

  15. Wouter Wolters commented on patch set 3 08/03/12, 12:13

    Anyone?
  16. Wouter Wolters commented on patch set 3 08/03/12, 12:13

    Looks good to me, but someone else must approve Rebased, IMHO this one had enough votes
  17. Christian Kuhn commented on patch set 4 V 0 08/03/12, 12:13

    by team member; Looks good to me, approved Merged. Since this is not a code bugfix, it should be ok for for 6.0 only.
  18. Christian Kuhn merged patch set 4 08/03/12, 12:13