10597[BUGFIX] Escape variable in regular expression
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 8
-
Dmitry Dulepov commented on patch set 1 05/20/12, 11:07
I would prefer that you didn't submit this Use preg_quote() instead. -
Stefan Neufeind commented on patch set 1 05/20/12, 11:07
Looks good to me, but someone else must approve looks obvious -
Philipp Gampe commented on patch set 2 05/20/12, 11:07
@Dmitry you are right, I forgot about that build in function. This is of course much cleaner.class.tx_install.php:1949missing second parameter '/' -
Philipp Gampe commented on patch set 2 1 comment 05/20/12, 11:07
I would prefer that you didn't submit this Competing changeset from Stefan: https://review.typo3.org/#/c/10943/ I will abandon this one, once the other is merged. -
Philipp Gampe uploaded patch set 2 05/20/12, 11:07
-
Mr. Jenkins commented on patch set 1 05/20/12, 11:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3793/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/20/12, 11:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3884/ : SUCCESS -
Philipp Gampe commented on patch set 2 05/20/12, 11:07
Abandoned https://review.typo3.org/#/c/10943/