Review main Abandoned

10597[BUGFIX] Escape variable in regular expression

Philipp Gampe CR 0 V 0 Easy +3 −3 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 8

  1. Dmitry Dulepov commented on patch set 1 05/20/12, 11:07

    I would prefer that you didn't submit this Use preg_quote() instead.
  2. Stefan Neufeind commented on patch set 1 05/20/12, 11:07

    Looks good to me, but someone else must approve looks obvious
  3. Philipp Gampe commented on patch set 2 05/20/12, 11:07

    @Dmitry you are right, I forgot about that build in function. This is of course much cleaner.

    class.tx_install.php:1949

    missing second parameter '/'
  4. Philipp Gampe commented on patch set 2 1 comment 05/20/12, 11:07

    I would prefer that you didn't submit this Competing changeset from Stefan: https://review.typo3.org/#/c/10943/ I will abandon this one, once the other is merged.
  5. Philipp Gampe uploaded patch set 2 05/20/12, 11:07

  6. Mr. Jenkins commented on patch set 1 05/20/12, 11:07

  7. Mr. Jenkins commented on patch set 2 05/20/12, 11:07

  8. Philipp Gampe commented on patch set 2 05/20/12, 11:07