Review main Merged

1066[BUGFIX] Make backend layout dropdown in CE editform translateable

Stefano Kowalke CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Chris topher +1
    • Steffen Kamper +1
  • Verified V +2
    • Jigal van Hemert +2
    • Steffen Kamper +1

Files 1

Review log 8

  1. Steffen Kamper commented on patch set 1 04/06/11, 17:36

    (1 inline comment)

    class.tx_cms_backendlayout.php:152

    i would prefer t3lib_div::isFirstPartOfStr($column['name', 'LLL:')
  2. Steffen Kamper commented on patch set 2 04/06/11, 17:36

    Verified; Looks good to me, but someone else must approve
  3. Stefano Kowalke commented on patch set 2 04/06/11, 17:36

    No score; No score I cant submit the change be myself. This have done by a core member.
  4. Stefano Kowalke uploaded patch set 2 04/06/11, 17:36

  5. Stefano Kowalke commented on patch set 2 04/06/11, 17:36

    Verified; Looks good to me, but someone else must approve
  6. Chris topher commented on patch set 2 04/06/11, 17:36

    Looks good to me, but someone else must approve
  7. Jigal van Hemert commented on patch set 2 V 0 04/06/11, 17:36

    by team member; Looks good to me, approved Go ahead and submit it. Please push a change for 4_5 too!
  8. Jigal van Hemert merged patch set 2 04/06/11, 17:36