Review TYPO3_4-7 Merged

10701[BUGFIX] Localize command must preserve type

Francois Suter CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

When the TCEmain command "localize" is used on a table that has
a type attribute, this type is not copied automatically. This
may lead to a discrepancy between the parent record and its
translations. The type must be copied when localizing.

Review

  • Code review CR +2
    • Francois Suter +2
  • Verified V +2
    • Francois Suter +2

Files 1

Review log 5

  1. Tolleiv Nietsch commented on patch set 1 04/23/12, 13:44

    Afaik nobody except the Release manager is allowed to merge sth. into 4.7 ---- and in this particular case it's also quite critical to just commit it without having feedback from other testers.
  2. Francois Suter commented on patch set 1 V 0 04/23/12, 13:44

    by team member; Looks good to me, approved Simple fix, already merged in master
  3. Francois Suter merged patch set 1 04/23/12, 13:44

  4. Oliver Hader commented on patch set 1 04/23/12, 13:44

    I'm going to revert this change and will re-add it to Gerrit for TYPO3_4-7.
  5. Oliver Hader commented on patch set 1 04/23/12, 13:44

    See https://review.typo3.org/#/c/10712/ - can be readded after the 4.7.0 release