10706[BUGFIX] Properly load existing usergroups in task
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
Files 1
Review log 12
-
Philipp Gampe commented on patch set 1 06/21/12, 18:47
(1 inline comment) Actually the commit message is confusing. It should be something like: The create backend user task did not properly load the usergroups of an existing user, because it wrongly assumes that the groups are provided as array. Actually the groups are provided as raw DB field, thus no conversion is needed. Can you take care of fixing the commit message (if you agree on this).s/taks/task/ -
Bart Dubelaar commented on patch set 1 06/21/12, 18:47
@Philipp: Totally agree, I will commit it again -
Dmitry Dulepov commented on patch set 2 06/21/12, 18:47
Looks good to me, approved -
Oliver Klee commented on patch set 2 06/21/12, 18:47
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 V 0 06/21/12, 18:47
by team member; Looks good to me, approved Additional +1 on reading and testing. Merged. -
Georg Ringer commented on patch set 2 06/21/12, 18:47
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 06/21/12, 18:47
Looks good to me, but someone else must approve -
Bart Dubelaar uploaded patch set 2 06/21/12, 18:47
-
Mr. Jenkins commented on patch set 1 06/21/12, 18:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3827/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/21/12, 18:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3829/ : SUCCESS -
Wouter Wolters commented on patch set 2 06/21/12, 18:47
Looks good to me, but someone else must approve -
Christian Kuhn merged patch set 2 06/21/12, 18:47