Review TYPO3_4-7 Merged

10913[BUGFIX] Custom HTML tags no longer malformed in IE

Stanislas Rolland CR +2 V +2 Easy +25 −3 updated 06/03/13, 20:49

Commit message

Custom HTML tags would get malformed while editing in IE.
If a tag is not present in HTML4 and the document mode
of IE is lower than IE9 Standards, then the tag is not
present in the DOM and not parsed correctly.
This is fixed by specifying possible custom tags in TSconfig
and creating dummy instances of the tags before loading
the contents in the DOM, also known as the Shiv trick.

Review

  • Code review CR +2
    • Stanislas Rolland +2
    • Bart Dubelaar +1
  • Verified V +2
    • Stanislas Rolland +2

Files 3

Review log 3

  1. Stanislas Rolland commented on patch set 1 V 0 07/02/12, 03:46

    by team member; Looks good to me, approved
  2. Bart Dubelaar commented on patch set 1 07/02/12, 03:46

    Looks good to me, but someone else must approve
  3. Stanislas Rolland merged patch set 1 07/02/12, 03:46