10942[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mattias Nilsson +1
- Steffen Ritter +1
- Helmut Hummel +1
-
Verified V +2
- Benni Mack +2
Issues 1
Files 1
Review log 18
-
Stanislas Rolland uploaded patch set 2 03/22/13, 16:55
-
Stanislas Rolland uploaded patch set 3 03/22/13, 16:55
-
Benni Mack uploaded patch set 4 03/22/13, 16:55
-
Benni Mack uploaded patch set 5 03/22/13, 16:55
-
Stanislas Rolland commented on patch set 6 03/22/13, 16:55
Not sure about this change. Should we update sys_refindex or sys_file_reference? The file list tooltip (in the Ref. column) shows the references from sys_refindex, but then links to ElementInformationController which shows a different set of references based on sys_file_reference. Something is wrong here. Why should we have two different reference indexes when it comes to files? -
Stefan Neufeind commented on patch set 6 03/22/13, 16:55
(2 inline comments)SoftReferenceIndex.php:584just to make sure: it's $link_param here and not $linkHandlerValue possibly? identifier still needs to carry the file: prefix?SoftReferenceIndex.php:600comment on separate line -
Benni Mack uploaded patch set 6 03/22/13, 16:55
-
Benni Mack commented on patch set 6 V 0 03/22/13, 16:55
by team member; Looks good to me, approved Tested it, and works as expected. However, just to be clear: sys_file_reference is not for tracking references to softrefparser links, but to other DB tables with additional metadata. -
Helmut Hummel commented on patch set 6 03/22/13, 16:55
Looks good to me, but someone else must approve change indeed look obvious I will add unit tests later this evening -
Steffen Ritter commented on patch set 6 03/22/13, 16:55
Looks good to me, but someone else must approve well, softrefparser is crazy bitch - but looks good. -
Mattias Nilsson commented on patch set 6 03/22/13, 16:55
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/22/13, 16:55
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3887/ : FAILURE -
Mr. Jenkins commented on patch set 2 03/22/13, 16:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3888/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/22/13, 16:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3891/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/22/13, 16:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6216/ : SUCCESS -
Mr. Jenkins commented on patch set 5 03/22/13, 16:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6239/ : SUCCESS -
Mr. Jenkins commented on patch set 6 03/22/13, 16:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6240/ : SUCCESS -
Benni Mack merged patch set 7 03/22/13, 16:55