Review main Merged

10946[FEATURE] Add Progress bar for task progress

Ingo Renner CR +2 V +2 Normal +106 −0 updated 06/03/13, 20:49

Commit message

Some tasks may want to provide the user with information about how
far progress of their jobs has come.

Currently there is no way to do this in a nice way. The existing
method getAdditionalInformation() does not allow to output HTML.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Mattias Nilsson +1
    • Nikolas Hagelstein +1
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2
    • Mattias Nilsson +1

Files 5

Review log 10

  1. Ingo Renner uploaded patch set 2 05/10/12, 20:21

  2. Oliver Klee commented on patch set 2 05/10/12, 20:21

    (1 inline comment)

    class.tx_scheduler_module.php:534

    AFAIK, in CSS the percentage does not need to be rounded. When the progress bar is more than 100 pixels wide, a non-rounded percentage will make the progressions a lot smoother. (At least this was the case with the progress bar in the phpunit extension where I dropped the rounding.)
  3. Nikolas Hagelstein commented on patch set 2 05/10/12, 20:21

    Looks good to me, but someone else must approve
  4. Jigal van Hemert commented on patch set 2 V 0 05/10/12, 20:21

    by team member; Looks good to me, approved
  5. Philipp Gampe commented on patch set 2 05/10/12, 20:21

    Looks good to me, but someone else must approve
  6. Mattias Nilsson commented on patch set 2 05/10/12, 20:21

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 05/10/12, 20:21

  8. Mr. Jenkins commented on patch set 2 05/10/12, 20:21

  9. Nicole Hummel commented on patch set 2 05/10/12, 20:21

    Oliver would say "where are the unit tests" ;-)
  10. Jigal van Hemert merged patch set 2 05/10/12, 20:21