10946[FEATURE] Add Progress bar for task progress
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Mattias Nilsson +1
- Nikolas Hagelstein +1
- Philipp Gampe +1
-
Verified V +2
- Jigal van Hemert +2
- Mattias Nilsson +1
Files 5
Review log 10
-
Ingo Renner uploaded patch set 2 05/10/12, 20:21
-
Oliver Klee commented on patch set 2 05/10/12, 20:21
(1 inline comment)class.tx_scheduler_module.php:534AFAIK, in CSS the percentage does not need to be rounded. When the progress bar is more than 100 pixels wide, a non-rounded percentage will make the progressions a lot smoother. (At least this was the case with the progress bar in the phpunit extension where I dropped the rounding.) -
Nikolas Hagelstein commented on patch set 2 05/10/12, 20:21
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 2 V 0 05/10/12, 20:21
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 2 05/10/12, 20:21
Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 2 05/10/12, 20:21
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/10/12, 20:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3892/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/10/12, 20:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3893/ : SUCCESS -
Nicole Hummel commented on patch set 2 05/10/12, 20:21
Oliver would say "where are the unit tests" ;-) -
Jigal van Hemert merged patch set 2 05/10/12, 20:21