Review main Merged

1096[FEATURE] add .gitignore for common file exclusions

Peter Niederlag CR +2 V +1 Easy +24 −0 updated 06/03/13, 20:49

Commit message

porting what was in svn:ignore before
needs to be aplied to all branches separatly, once we agree

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Steffen Ritter +1
  • Verified V +1
    • Steffen Ritter +1
    • Andreas Wolf +1

Files 1

Review log 8

  1. Peter Niederlag uploaded patch set 2 03/08/11, 19:24

  2. Peter Niederlag commented on patch set 2 03/08/11, 19:24

    @andreas: I'd like not to add .orig and .rej as then you can easily see seem and use 'git clean' for cleanup @tolleiv: why should we ignore .gitignore? if you want to adapt/change exlude patterns use .git/info/exclude
  3. Andreas Wolf commented on patch set 1 03/08/11, 19:24

    Verified; I would prefer that you didn't submit this

    .gitignore:8

    IMHO you should add these: *~ (temporary files left by e.g. vim) .idea (PHPstorm project) *.orig *.bak *.rej *.swp
  4. Andreas Wolf commented on patch set 2 03/08/11, 19:24

    Looks good to me, approved As we now have two +1s, this is ready for committing :-)
  5. Andreas Wolf commented on patch set 2 03/08/11, 19:24

    Verified; Looks good to me, but someone else must approve Ok, didn't know "git clean" until now... In this case the change is fine with me.
  6. Tolleiv Nietsch commented on patch set 1 03/08/11, 19:24

    Could you add ".idea" (PHPStorm) and ".gitignore" itself ?
  7. Steffen Ritter commented on patch set 2 03/08/11, 19:24

    Verified; Looks good to me, but someone else must approve definitely like this :)
  8. Andreas Wolf merged patch set 2 03/08/11, 19:24