11028[TASK] Clean up phpDoc comments in t3lib_befunc
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Tolleiv Nietsch +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Tolleiv Nietsch +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 10
-
Tolleiv Nietsch commented on patch set 1 05/07/12, 17:20
Do not submit The patch also touches (deprecated) methods: implodeTSParams updatePagesTSconfig compilePreviewKeyword isPidInVersionizedBranch. Would you please handle them in a separate RFC? -
Mr. Jenkins commented on patch set 1 05/07/12, 17:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3944/ : SUCCESS -
Tolleiv Nietsch commented on patch set 2 05/07/12, 17:20
Verified; Looks good to me, but someone else must approve Better :) ---- tested with another "php -l" syntax check - to make sure nothing broke by accident. -
Philipp Gampe commented on patch set 2 05/07/12, 17:20
Looks good to me, but someone else must approveclass.t3lib_befunc.php:915comment lines should not be longer than 80 chars -
Philipp Gampe voted on patch set 2 V 0 05/07/12, 17:20
-
Mr. Jenkins commented on patch set 2 05/07/12, 17:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3945/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/07/12, 17:20
For the deprecated stuff I created a Forge-issue: http://forge.typo3.org/issues/36887 -
Wouter Wolters uploaded patch set 2 05/07/12, 17:20
-
Christian Kuhn commented on patch set 2 V 0 05/07/12, 17:20
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 05/07/12, 17:20